fix strange space at the top when FlexWrap (#522)#530
fix strange space at the top when FlexWrap (#522)#530sheckspir wants to merge 3 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
| } else { | ||
| anchorInfo.mCoordinate = mOrientationHelper.getStartAfterPadding() + | ||
| savedState.mAnchorOffset; | ||
| } |
There was a problem hiding this comment.
I think this is not a correct way to fix the issue.
Actually some of the tests in FlexboxLayoutMangerTests are failing after patching this PR.
Couldn't look into the issue carefully, but I guess what needs to be cared is not whether the main axis direction is horizontal, but whether the flex wrap is nowrap.
thagikura
left a comment
There was a problem hiding this comment.
Thanks for the PR!
But looks like existing tests are failing, also is it possible to add a test to FlexboxLayoutManager to verify the fix?
|
@thagikura Yes, you was right. It was a bad way to resolve it. I looked on it some more, and I saw, that you change OrientationHelper for a situation, when flexWrap != NOWRAP. It makes sense. Because scrolling, in this case, goes otherways |
|
Sorry for the delayed replay.. Thanks for the new commit! Yup, the fix looks like what I intended. But noticed that FlexboxLayoutManager.testDrawDirtyFlexLine_multi_viewTypes_direction_row fails consistently. Haven't spotted what causes the failure, but is it possible to check on your end, too? |
No description provided.